Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use * for external crates #70

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Dec 1, 2021

Remove wildcard use statements from intel-mkl-tool, because it
causes problems like #68

Fix #68

Remove wildcard `use` statements from `intel-mkl-tool`, because it
causes problems like rust-math#68
@hombit
Copy link
Contributor Author

hombit commented Dec 3, 2021

Hi @termoshtt, please could you look into this? The issue #68 is really annoying and I see a lot of troubles people have with it

@jianshu93
Copy link

I have the same build error. How use specify version 1.0.48 for a package depending ton it?

THanks,

Jianshu

@hombit
Copy link
Contributor Author

hombit commented Dec 15, 2021

@jianshu93 This PR resolves the root of the problem, it doesn't pin or limit anyhow version used by intel-mkl-tool. I temporary solved this issue in my project in the same way as others did: just specified anyhow version in my Cargo.toml:
light-curve/light-curve@15364a8

@jianshu93
Copy link

Thanks for quick response.

Jianshu

@adam-azarchs
Copy link

Depending on what features are enabled, this is also an issue in

use anyhow::*;

@hombit
Copy link
Contributor Author

hombit commented Jan 26, 2022

@adam-azarchs this PR was for intel-mkl-tool only, but I can do the same for other two crates as well

@hombit hombit changed the title tool: remove use * for external crates Remove use * for external crates Jan 26, 2022
@hombit
Copy link
Contributor Author

hombit commented Jan 26, 2022

Thank you, @adam-azarchs, I did the same change in intel-mkl-src/intel-mkl-src/build.rs

@njaard
Copy link

njaard commented Mar 25, 2022

@hombit I have forked this crate and applied this patch. https://github.com/njaard/mkl-src/

With appreciation to @termoshtt I'd like to ask you to make further contributions to my fork's repository due to the original author's absence.

termoshtt added a commit that referenced this pull request Jul 28, 2022
Signed-off-by: Toshiki Teramura <toshiki.teramura@gmail.com>
@termoshtt termoshtt self-requested a review July 28, 2022 08:17
@termoshtt termoshtt merged commit c9cbceb into rust-math:master Jul 28, 2022
termoshtt added a commit that referenced this pull request Jul 28, 2022
Signed-off-by: Toshiki Teramura <toshiki.teramura@gmail.com>
termoshtt added a commit that referenced this pull request Aug 25, 2022
termoshtt added a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intel-mkl-tool: Compilation problem with anyhow 1.0.49
5 participants