-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use * for external crates #70
Conversation
Remove wildcard `use` statements from `intel-mkl-tool`, because it causes problems like rust-math#68
Hi @termoshtt, please could you look into this? The issue #68 is really annoying and I see a lot of troubles people have with it |
I have the same build error. How use specify version 1.0.48 for a package depending ton it? THanks, Jianshu |
@jianshu93 This PR resolves the root of the problem, it doesn't pin or limit |
Thanks for quick response. Jianshu |
Depending on what features are enabled, this is also an issue in intel-mkl-src/intel-mkl-src/build.rs Line 25 in 84a464e
|
@adam-azarchs this PR was for |
Thank you, @adam-azarchs, I did the same change in |
@hombit I have forked this crate and applied this patch. https://github.com/njaard/mkl-src/ With appreciation to @termoshtt I'd like to ask you to make further contributions to my fork's repository due to the original author's absence. |
Signed-off-by: Toshiki Teramura <toshiki.teramura@gmail.com>
Signed-off-by: Toshiki Teramura <toshiki.teramura@gmail.com>
Remove wildcard
use
statements fromintel-mkl-tool
, because itcauses problems like #68
Fix #68