Fixup Mac exception stream #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `EXC_CRASH` exceptions are now unwrapped (if valid) and the wrapped exception is the one written to the minidump * `EXC_RESOURCE` and `EXC_GUARD` are now properly handled to report the upper 32-bits as `exception_flags` * The `exception_address` now properly takes `EXC_BAD_ACCESS` into account rather than using the subcode for the address regardless of the exception type * The exception type (kind), full 64-bit code, and full 64-bit subcode (if it exists) are now written to `exception_information` so that no exception data is lost and a minidump parser can extract those full details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXC_CRASHexceptions are now unwrapped (if valid) and the wrapped exception is the one written to the minidumpEXC_RESOURCEandEXC_GUARDare now properly handled to report the upper 32-bits asexception_flagsexception_addressnow properly takesEXC_BAD_ACCESSinto account rather than using the subcode for the address regardless of the exception typeexception_informationso that no exception data is lost when truncated for the 32-bitexception_codeandexception_flags, and a minidump parser can extract those full detailsAlso updates
crash-contextandminidump/-commoncrates.Resolves: #33
Resolves: #34