Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize ARM and AArch64 support on both Linux and Android, add support for x86-64 on Android #81

Merged
merged 2 commits into from Jun 13, 2023
Merged

Stabilize ARM and AArch64 support on both Linux and Android, add support for x86-64 on Android #81

merged 2 commits into from Jun 13, 2023

Conversation

gabrielesvelto
Copy link
Contributor

No description provided.

@gabrielesvelto
Stabilize ARM and AArch64 support on both Linux and Android, add supp…
f46d32c 
…ort for x86-64 on Android

This *does not* add support for i686 on Android as it would require
significant work for almost no benefit. Android emulators usually use
x86-64 and only very old versions run on i686.
@gabrielesvelto
Properly merge properties when merging adjacent mappings
a88cc13 
This fixes a regression introduced in
e706902 which prevented stack mappings
from being correctly merged on Android.
This was referenced Jun 7, 2023
Closed
Merged
Jake-Shadle
Jake-Shadle approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable, but we really should find a nice way of adding tests, or at least sanity checks of some of this stuff to make reviews easier.

@gabrielesvelto
Copy link
Contributor Author

This change looks reasonable, but we really should find a nice way of adding tests, or at least sanity checks of some of this stuff to make reviews easier.

Is it possible to run tests on Android hosts in GitHub CI? I suppose we could use an emulator, that'd cover the x86-64 part at least. Once I merge this into Firefox we'll be running end-to-end tests on both Android hardware and the emulator but it'll still be nicer to have tests here.

@gabrielesvelto gabrielesvelto merged commit 76021df into rust-minidump:main Jun 13, 2023
13 checks passed
@Jake-Shadle
Copy link
Collaborator

Well tests are harder for Android, when saying sanity checks I was more thinking just dumping out byte buffers and ensuring they can be interpreted correctly across changes in the code/libc/nix, but obviously has much lower value. But might be worth at least mentioning that Firefox is running more tests in addition to those in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabrielesvelto @Jake-Shadle