Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android support for the i686 and x86-64 targets to the crash-context crate #76

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

gabrielesvelto
Copy link
Contributor

Checklist

  • [✓] I have read the Contributor Guide
  • [✓] I have read and agree to the Code of Conduct
  • [✓] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This PR adds Android support for the i686 and x86-64 targets. This is largely used within emulators for testing. Note that I didn't add the architectures as supported in the top-level README.md file because I am still in the process of stabilizing Android support in the minidump-writer crate. Once that's done adding support within the crate should be trivial.

Related Issues

N/A

@gabrielesvelto
Copy link
Contributor Author

The failure on macOS appears to be an issue with minidump-writer that has been potentially surfaced by new Rust versions. We're casting a pointer with a 4-bytes alignment into one that requires 8-bytes alignment. I'll file an issue and fix it.

@gabrielesvelto
Copy link
Contributor Author

I prepared a PR to fix the failure here (here it is). @Jake-Shadle do you have some time to review this as well as rust-minidump/minidump-writer#81 ?

Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the other one, I think this is good to go since they are separate issues.

@Jake-Shadle Jake-Shadle merged commit 5e907ff into EmbarkStudios:main Jun 13, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants