Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linfa 0.6 update #12

Closed
wants to merge 9 commits into from
Closed

Linfa 0.6 update #12

wants to merge 9 commits into from

Conversation

quietlychris
Copy link
Member

Work-in-progress for update to linfa v0.6, including removing mdbook-scientific, adding a linear regression model, and adding CI for the code.

@quietlychris
Copy link
Member Author

I'm requesting an initial review for these changes, which updates all code to 0.6, removes mdook-scientific, re-structures the repository, and adds content for linear regression. I realize this should probably have been a set of smaller PRs, but one thing led to another, and i think the end result is comprehensive enough for a thumbs-up or thumbs-down approach for these changes. I also think this should make it easier for new content to be added in the future.

@quietlychris quietlychris marked this pull request as ready for review December 28, 2022 03:36
@quietlychris quietlychris changed the title [WIP] Linfa 0.6 update Linfa 0.6 update Dec 28, 2022
@bytesnake
Copy link
Member

bytesnake commented Dec 29, 2022 via email

.gitignore Outdated
src/assets
plots/*
target/
Cargo.lock

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this newline is for?

examples/kmeans.rs Outdated Show resolved Hide resolved
@YuhanLiin
Copy link

Generating plots in Rust requires a surprising amount of boilerplate.

@quietlychris
Copy link
Member Author

Yeah, the boilerplate is a bit of a pain to be honest; it's actually one of the reasons that I think having a book like this is useful; it can be a little frustrating trying to figure out how to do that by yourself (the API is extensive), so I'm hoping this will cut down on the time that people need to get going.

At some point, I'm hoping that plotters might consider working on a higher-level API with a bunch on default in the Builder pattern or something, combined with an ndarray plug-in or something, but it doesn't seem to be a high priority and I don't really have the time to design something like that myself at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants