-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linfa 0.6 update #12
Linfa 0.6 update #12
Conversation
I'm requesting an initial review for these changes, which updates all code to 0.6, removes |
Hi Chris,
I'm currently on vacation and will return latest on 07/01, will review then.
Cheers
28.12.2022 04:33:10 chris m ***@***.***>:
… @quietlychris[https://github.com/quietlychris] requested your review on: #12[#12] [WIP] Linfa 0.6 update.
—
Reply to this email directly, view it on GitHub[#12 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAHRRKNZZVHUMIO3VI7NGIDWPOYHBANCNFSM6AAAAAAQU2QXYU].
You are receiving this because your review was requested.[Verfolgungsbild][https://github.com/notifications/beacon/AAHRRKLZNLESJEGFTW4JWXDWPOYHBA5CNFSM6AAAAAAQU2QXYWWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAADY7JIX7A.gif]
|
.gitignore
Outdated
src/assets | ||
plots/* | ||
target/ | ||
Cargo.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this newline is for?
Generating plots in Rust requires a surprising amount of boilerplate. |
Yeah, the boilerplate is a bit of a pain to be honest; it's actually one of the reasons that I think having a book like this is useful; it can be a little frustrating trying to figure out how to do that by yourself (the API is extensive), so I'm hoping this will cut down on the time that people need to get going. At some point, I'm hoping that |
Work-in-progress for update to
linfa v0.6
, including removingmdbook-scientific
, adding a linear regression model, and adding CI for the code.