bitmap: Add try_format() to AndroidBitmapInfo to handle unexpected formats without panicking
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Jun 7, 2023
MarijnS95
changed the title
format(): try_format()
MarijnS95
approved these changes
Jun 7, 2023
|
A doc-comment might be nice too, pointing the user in the right direction. |
|
@dcsommer can you still add a doc-comment and changelog entry? |
|
Done. Let me know if it works for you.
…On Wed, Aug 9, 2023 at 1:33 AM Marijn Suijten ***@***.***> wrote:
@dcsommer <https://github.com/dcsommer> can you still add a doc-comment
and changelog entry?
—
Reply to this email directly, view it on GitHub
<#395 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIIKIC53E5BEZZQPMJEPE3XUNDPHANCNFSM6AAAAAAY5DF3X4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
MarijnS95
changed the title
format(): try_format()try_format() to AndroidBitmapInfo to handle unexpected formats without panicking
MarijnS95
reviewed
Aug 9, 2023
We have observed panics in practice for this API due to unexpected formats. We need to compare the format without panicking.
MarijnS95
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed panics in practice for this API due to unexpected formats. We need to compare the format without panicking.