Commits on Sep 14, 2023

1. ndk: Bump MSRV from 1.64 to 1.66 …

   It is older than 6 months and now required for the `toml_edit`
   dependency (used by `num_enum_derive`).  At the same time `num_enum`
   relies on arbitrary enum discriminants (for discriminated enums
   with tuple/struct variants) introduced by Rust 1.66 in order to
   implement `#[num_enum(catch_all)]`.  This feature comes in use to
   replace the manual `match` blocks when implementing conversions for
   `HardwareBufferFormat` when also having an `Unknown(u32)` to catch
   valid private/vendor values that won't ever be described inside the
   NDK.  This change effectively reverts #407 to its initial state, where a
   `catch_all` implementation was used.
   
   For the latter the intent is however to use this feature sparingly.
   In most APIs new values are few and far between, so treating these as
   an `Err` via `TryFromPrimitive` is desired to provoke upstream issue
   reports and quick turnaround on new values.  Same for `enum`s that are
   used to pass values into functions: it is desired to only pass known
   values (by this `ndk` crate) into those, anything else should similarly
   be reported and added upstream.  In these cases a `#[non_exhaustive]`
   allows us to do so with a tiny non-breaking patch release.

   

   MarijnS95 committed Sep 14, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8d0648d
   • Browse repository at this point

   Copy the full SHA

   8d0648d View commit details

   Browse the repository at this point in the history