ndk/media_error: Flatten MediaStatus and MediaError with catch_all
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
media-error-flatten-status
branch
from
3d5a700
to
bff5212
Compare
MarijnS95
force-pushed
the
msrv-1.66
branch
2 times, most recently
from
02a8d56
to
8d0648d
Compare
Since bumping our MSRV to 1.66 `num_enum` provides a `catch_all` variant which we can use to store yet-unknown or yet-unmapped error codes, rather than having them in a secondary `enum` which derives `thiserror`. This also allows us to get rid of a manual `match` statement, which can be (but could already have been...) generated by `num_enum` via `TryFromPrimitive` before.
MarijnS95
force-pushed
the
media-error-flatten-status
branch
from
bff5212
to
ea4dcc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #431Since bumping our MSRV to 1.66
num_enumprovides acatch_allvariant which we can use to store yet-unknown or yet-unmapped error codes, rather than having them in a secondaryenumwhich derivesthiserror.This also allows us to get rid of a manual
matchstatement, which can be (but could already have been...) generated bynum_enumviaTryFromPrimitivebefore.