ndk/event: Implement SourceClass bitflag and provide Source::class() getter
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Dec 25, 2023
2 tasks
rib
reviewed
Jan 18, 2024
MarijnS95
force-pushed
the
event-source-class
branch
from
485b34e
to
e5b8669
Compare
MarijnS95
changed the title
SourceClass enum and provide Source::class() getterSourceClass bitflag and provide Source::class() getter
MarijnS95
commented
Jan 18, 2024
rib
reviewed
Jan 19, 2024
MarijnS95
force-pushed
the
event-source-class
branch
2 times, most recently
from
80b6e1a
to
da5441f
Compare
rib
approved these changes
Jan 19, 2024
rib
requested changes
Jan 19, 2024
|
@rib good point. Since it's |
MarijnS95
force-pushed
the
event-source-class
branch
from
da5441f
to
250f19b
Compare
rib
requested changes
Jan 26, 2024
MarijnS95
force-pushed
the
event-source-class
branch
from
250f19b
to
c724f6a
Compare
…ss()` getter This `enum` was never `pub` even though it serves a slight purpose to more easily classify various event sources, which is accounted for in the bitmask-like value of `AINPUT_SOURCE_XXX`. Even though every source currently only appears to use a single class value, the class variants all describe an individual bit and should be treated as a bitflags type.
… to be extended Android may return values in `bitflags` that are not yet mapped or recognized in the `ndk` crate. This makes functions like `all()` and `!` behave unexpectedly when they truncate or limit their operation to known bits exclusively. A more likable solution is disabling functions that are susceptible to this, as was done in the `ash` crate.
MarijnS95
force-pushed
the
event-source-class
branch
from
c724f6a
to
71ee97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
enumwas neverpubeven though it serves a slight purpose to more easily classify various event sources, which is accounted for in the bitmask-like value ofAINPUT_SOURCE_XXX.