fix build on modern MacOS systems #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple switched c++ stdlibs to support c++1z features, and deprecated the old one. the ways that interacts with cmake are vast and unknowable. apparently they haven't gotten around to fixing that yet, which affects libui's cmake-based build toolchain. what this patch does is essentially just force the new stdlib on apple systems. i don't think this will cause issues with old (ie, pre-Sierra) macos versions, but perhaps further testing would be helpful. at any rate, it fixes a problem that was basically blocking anyone on a modern macos install from using libui-rs, which is nice.
barzamin
force-pushed
the
fix-macos-build
branch
from
fe9d815
to
532ee7e
Compare
NoraCodes
reviewed
Jan 30, 2019
|
@NoraCodes i did test it on a VM of Mojave :) |
|
Great! Let's merge it. |
barzamin
added a commit
that referenced
this pull request
Feb 4, 2019
|
Thanks for this PR! Am I right that this is not included in the current release (0.3.0 from 2018-05-04)? When I use instead of the inital build issue is gone, otherwise the build fails as described in corresponding issues. Will there be a new release with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apple switched c++ stdlibs to support c++1z features, and deprecated the old one.
the ways that interacts with cmake are vast and unknowable. apparently they haven't
gotten around to fixing that yet, which affects libui's cmake-based build toolchain.
what this patch does is essentially just force the new stdlib on apple systems.
i don't think this will cause issues with old (ie, pre-Sierra) macos versions, but
perhaps further testing would be helpful.
at any rate, it fixes a problem that was basically blocking anyone on a modern
macos install from using libui-rs, which is nice.
fixes #38 :)