Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use direct ops in Rem<T> for Complex<T> #25

Merged
merged 1 commit into from May 21, 2018
Merged

Use direct ops in Rem<T> for Complex<T> #25

merged 1 commit into from May 21, 2018

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 21, 2018

This avoids overflow issues with dividing by norm_sqr, and is
probably faster too, just for being simpler.

@cuviper
Use direct ops in Rem<T> for Complex<T>
b6ad659 
This avoids overflow issues with dividing by `norm_sqr`, and is
probably faster too, just for being simpler.
@cuviper
Copy link
Member Author

cuviper commented May 21, 2018

bors r+

bors bot added a commit that referenced this pull request May 21, 2018
@bors @cuviper
Merge #25
11ac7d6 
25: Use direct ops in Rem<T> for Complex<T> r=cuviper a=cuviper

This avoids overflow issues with dividing by `norm_sqr`, and is
probably faster too, just for being simpler.

Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 21, 2018

Build succeeded

@bors bors bot merged commit b6ad659 into rust-num:master May 21, 2018
@cuviper cuviper mentioned this pull request May 21, 2018
Closed
@cuviper cuviper deleted the real-rem branch February 6, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cuviper