Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float trait doesn't require copysign function #152

Closed
hombit opened this issue Feb 1, 2020 · 2 comments · Fixed by #207
Closed

Float trait doesn't require copysign function #152

hombit opened this issue Feb 1, 2020 · 2 comments · Fixed by #207
Labels
enhancement good first issue help wanted

Comments

@hombit
Copy link

hombit commented Feb 1, 2020

Float trait should require copysign function introduced in Rust 1.35: f32::copysign, f64::copysign
@cuviper
Copy link
Member

cuviper commented Feb 1, 2020

We can add it as long as there's a default implementation, but I think that should be possible. Using the std method should also be conditional on compiler support.

@cuviper
Copy link
Member

cuviper commented Feb 1, 2020

When libm is enabled, we can also use its copysign/copysignf for older-std and no_std builds.

peartt added a commit to peartt/num-traits that referenced this issue Feb 13, 2020
@peartt
Added copysign fixes rust-num#152
9403c21
peartt added a commit to peartt/num-traits that referenced this issue Feb 13, 2020
@peartt
Added copysign fixes rust-num#152
5c8613a
@XAMPPRocky XAMPPRocky mentioned this issue Mar 17, 2021
Merged
@bors bors bot closed this as completed in edb4821 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add copysign XAMPPRocky/num-traits
2 participants
@cuviper @hombit