-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conversion of primitive integer types in const
context
#226
Conversation
const
context
Combines these commits— * const conversion support for primitive integer types Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * fix clippy errors Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * Prevent a warning when running tests and not `no_std` Author: Fredrick Brennan <copypaste@kittens.ph> Co-authored-by: Fredrick Brennan <copypaste@kittens.ph> Signed-off-by: Fredrick Brennan <copypaste@kittens.ph>
(Merged into MFEK@8271720 due to #189 (comment). You likely don't care and the maintainer does plan to return, just explaining the merge message above.) |
Oh, here's something you might indeed care about though @U007D—you probably want to add MFEK@54b6a41 to your branch because otherwise your PR adds a warning. |
It would be nice to have I tried to just add Compile error
As far as I can see, it should work, because the |
Hi -- I'm not inclined to merge any unstable features in the API, especially because I don't want the maintenance burden if that syntax changes at all. So I'm going to close this for now, but you're of course welcome to keep experimenting in a fork, and please feel free to reopen or file a new PR when the language has stabilized this. |
Combines these commits— * const conversion support for primitive integer types Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * fix clippy errors Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * Prevent a warning when running tests and not `no_std` Author: Fredrick Brennan <copypaste@kittens.ph> Co-authored-by: Fredrick Brennan <copypaste@kittens.ph> Signed-off-by: Fredrick Brennan <copypaste@kittens.ph>
Combines these commits— * const conversion support for primitive integer types Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * fix clippy errors Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * Prevent a warning when running tests and not `no_std` Author: Fredrick Brennan <copypaste@kittens.ph> Co-authored-by: Fredrick Brennan <copypaste@kittens.ph> Signed-off-by: Fredrick Brennan <copypaste@kittens.ph>
Combines these commits— * const conversion support for primitive integer types Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * fix clippy errors Signed-off-by: Fredrick Brennan <copypaste@kittens.ph> * Prevent a warning when running tests and not `no_std` Author: Fredrick Brennan <copypaste@kittens.ph> Co-authored-by: Fredrick Brennan <copypaste@kittens.ph> Signed-off-by: Fredrick Brennan <copypaste@kittens.ph>
Support primitive integer conversion via new
const_conversion
feature or when building with a version of the compiler whereconst_trait_impl
has stabilized.