-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let kernels use
the Logger
#218
Conversation
To explain this further:
This approach would allow kernels to simply |
Made a few more changes to push this |
Thanks for the PR, @kennystrawnmusic! I like the idea to give people a way to quickly add some debug printing to their kernels. However, I don't think that we should export the So I propose the following:
This way, we provide an easy way to get some output on the screen when getting started, without needing to provide and maintain a full framebuffer writer implementation. Does this sound good to you? (I also want to mention that I'm currently working on a rewrite of this crate in the |
Closing now — going to open a couple of new PRs in the next couple of hours to make the recommended changes. |
Since A, the next post in Edition 3 of phil-opp/blog_os is supposed to be all about text output, and B, the bootloader already defines a built-in way to do just that ― time to take the
Logger
out of itsbinary
cocoon and let everyoneuse
it.