Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Temporarily turn off warnings-as-errors for nightly CI jobs #1206

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ci: Temporarily turn off warnings-as-errors for nightly CI jobs #1206

merged 1 commit into from
Jun 17, 2024

Conversation

nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Jun 14, 2024 •
edited
Loading

The dead_code lint on nightly is currently incorrectly flagging a lot of structs as unused.

#1205

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
ci: Temporarily turn off warnings-as-errors for nightly CI jobs
716f9bc 
The dead_code lint on nightly is currently incorrectly flagging a lot of structs
as unused.
@nicholasbishop nicholasbishop mentioned this pull request Jun 14, 2024
Closed
@phip1611 phip1611 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 35663b5 Jun 17, 2024
15 checks passed
@phip1611 phip1611 deleted the bishop-nightly-allow-warn branch June 17, 2024 09:24
@phip1611 phip1611 mentioned this pull request Jul 31, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 Awaiting requested review from phip1611

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611