Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event support and general console protocol cleanup #44

Merged
merged 12 commits into from
Sep 26, 2018
Merged

Conversation

HadrienG2
Copy link
Contributor

@HadrienG2 HadrienG2 commented Sep 25, 2018

  • Implemented basic support for awaiting UEFI events.
  • Made Handle and Event different newtypes of void* so assigning one to the other is an error
    • No ergonomics are lost since from the user's point of view these are opaque types anyway.
  • Clarified the stateful nature of Pointer::get_state
  • Made text input protocol more consistent with pointer protocol
  • Improved documentation and method ordering of text output protocol

src/table/boot.rs Outdated Show resolved Hide resolved
src/table/boot.rs Outdated Show resolved Hide resolved
@HadrienG2
Copy link
Contributor Author

So... with the Status discussion delayed, are you satisfied with the general state of this MR?

Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's good. I haven't used events a lot with UEFI, so we might end up refactoring the API in the future.

@HadrienG2 HadrienG2 merged commit c3a2b2f into master Sep 26, 2018
@HadrienG2 HadrienG2 deleted the console-cleanup branch September 26, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants