Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Port::read and PortReadOnly::read to take &mut self #76

Merged
merged 2 commits into from May 9, 2019

Conversation

@MikailBag
Copy link
Contributor

MikailBag commented May 8, 2019

fixes #75

MikailBag added 2 commits May 8, 2019
@MikailBag

This comment has been minimized.

Copy link
Contributor Author

MikailBag commented May 8, 2019

Should I squash all changes in one commit?

@phil-opp phil-opp changed the title Change Port::read and PortReadOnly::read to take &mut self fixes #75 Change Port::read and PortReadOnly::read to take &mut self May 9, 2019
@phil-opp phil-opp merged commit e18f530 into rust-osdev:master May 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rust-osdev.x86_64 Build #20190508.2 succeeded
Details
@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented May 9, 2019

Thanks a lot!

phil-opp added a commit that referenced this pull request May 9, 2019
@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented May 9, 2019

Released as version 0.7.0

bors bot added a commit to phil-opp/blog_os that referenced this pull request May 9, 2019
604: Use `-serial stdio` instead of `-serial mon:stdio` r=phil-opp a=phil-opp

Fixes #602 

Post update in #605

606: Update x86_64 to version 0.7.0 r=phil-opp a=phil-opp

[Changelog](https://github.com/rust-osdev/x86_64/blob/master/Changelog.md#070):

- **Breaking**: `Port::read` and `PortReadOnly::read` now take `&mut self` instead of `&self` ([#76](rust-osdev/x86_64#76)).

Post update in #607

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.