Change Port::read and PortReadOnly::read to take &mut self #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I squash all changes in one commit? |
phil-opp
changed the title
|
Thanks a lot! |
phil-opp
added a commit
that referenced
this pull request
May 9, 2019
|
Released as version 0.7.0 |
bors bot
added a commit
to phil-opp/blog_os
that referenced
this pull request
May 9, 2019
604: Use `-serial stdio` instead of `-serial mon:stdio` r=phil-opp a=phil-opp Fixes #602 Post update in #605 606: Update x86_64 to version 0.7.0 r=phil-opp a=phil-opp [Changelog](https://github.com/rust-osdev/x86_64/blob/master/Changelog.md#070): - **Breaking**: `Port::read` and `PortReadOnly::read` now take `&mut self` instead of `&self` ([#76](rust-osdev/x86_64#76)). Post update in #607 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #75