Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch optional core feature to default std feature #168

Merged
merged 1 commit into from Jul 19, 2019
Merged

switch optional core feature to default std feature #168

merged 1 commit into from Jul 19, 2019

Conversation

abonander
Copy link
Collaborator

closes #167

cc @sfackler

I think with this merged I'll prepare the 0.8 release.

@sfackler
Copy link
Collaborator

There are two other cleanup things that may be worth considering for the 0.8 release:

  1. Removing OrderedMap and OrderedSet. As far as I can tell, no one actually uses them.
  2. Removing phf-builder (and with it the Cow-like enum we need to use internally). You're probably just better off using a HashMap.

@abonander abonander merged commit a932094 into rust-phf:master Jul 19, 2019
@abonander abonander mentioned this pull request Jul 19, 2019
Closed
@JohnTitor JohnTitor mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch "core" feature to be "std" feature on-by-default
2 participants
@abonander @sfackler