Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phf_macros on no_std #206

Merged
merged 1 commit into from Jun 6, 2021
Merged

Fix phf_macros on no_std #206

merged 1 commit into from Jun 6, 2021

Conversation

Kazurin-775
Copy link
Contributor

@Kazurin-775 Kazurin-775 commented May 31, 2021 •
edited

Currently, phf does not compile on no_std with features = ["macros"] enabled. This PR tries to fix this by adding default-features = false to phf_generator/Cargo.toml and phf_macros/Cargo.toml.

Tested on my own project and seemed to be working.

@JohnTitor
Copy link
Member

Could you rebase on top of master and resolve merge conflicts?

@Kazurin-775
Copy link
Contributor Author

@JohnTitor done.

@JohnTitor
Copy link
Member

Thanks!

@JohnTitor JohnTitor merged commit 7ebc9e7 into rust-phf:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kazurin-775 @JohnTitor