Remove Slice
and upgrade len
and is_empty
to const-fns
#224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
len
andis_empty
functions of the four PHF types are upgraded toconst-fn
s.Implementation Detail
In this implementation, I could only upgrade them when the
std
feature is turned off because of the definition ofSlice
. I'm not sure what the purpose of theDynamic
variant is onSlice
. Is there any reason we can't switch toslice
?