Skip to content

Commit

Permalink
Completely disable Web tests on Windows (#486)
Browse files Browse the repository at this point in the history
`continue-on-error` does not work as I was expecting. AFAIK GitHub
Action does not have a straightforward solution for optionally failing
jobs, see: actions/runner#2347

Closes #400
  • Loading branch information
newpavlov committed Jun 19, 2024
1 parent f345775 commit baae5fc
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,12 @@ jobs:
include:
- os: ubuntu-22.04
host: x86_64-unknown-linux-musl
- os: windows-2022
host: x86_64-pc-windows-msvc
# We get spurious failures on Windows, see:
# https://github.com/rust-random/getrandom/issues/400
continue-on-error: true
- os: macos-12
host: x86_64-apple-darwin
# We get spurious failures on Windows, see:
# https://github.com/rust-random/getrandom/issues/400
# - os: windows-2022
# host: x86_64-pc-windows-msvc
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit baae5fc

Please sign in to comment.