Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely disable Web tests on Windows #486

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Completely disable Web tests on Windows #486

merged 1 commit into from
Jun 19, 2024

Conversation

newpavlov
Copy link
Member

continue-on-error does not work as I was expecting. AFAIK GitHub Action does not have a straightforward solution for optionally failing jobs, see: actions/runner#2347

Closes #400

@newpavlov newpavlov requested a review from josephlr June 19, 2024 12:17
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, given that Edge is chrome-based anyway, I don't think the Windows tests were adding value here.

@josephlr josephlr merged commit baae5fc into master Jun 19, 2024
53 checks passed
@josephlr josephlr deleted the web_win branch June 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious failures of Web tests on Windows
2 participants