-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to GitHub Actions #180
Conversation
@newpavlov Do you know why AppVeyor Is still running? Is there some way to turn it off? |
I am not sure. Probably because we still have its config in the master branch. Hopefully it will be solved after merge. |
Yup, I can turn it off: (1) there's a webhook still registered and (2) AppVeyor was set up through my account. I'll clear it for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I just have a few nits/questions
with: | ||
profile: minimal | ||
target: ${{ matrix.target }} | ||
toolchain: nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using the stable toolchain for these targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis config was using nightly, so I haven't changed it. I can try stable
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a second thought, I think it's worth to keep it nightly
to allow early compiler bug detection if there will be any affecting us. I also will enable the cron job option to run CI periodically.
Closes #174
Converts most existing tests except related to WASM targets.