Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simd not used for rand_chacha #1017

Closed
bjorn3 opened this issue Aug 15, 2020 · 0 comments · Fixed by #1023
Closed

Simd not used for rand_chacha #1017

bjorn3 opened this issue Aug 15, 2020 · 0 comments · Fixed by #1023
Milestone
0.8 release

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Aug 15, 2020

The simd feature of ppv-lite86 was disabled in #979. Likely in response to cryptocorrosion/cryptocorrosion@785bfbe#diff-0304f94dbafa90393b3f5dfd9eb6f99c. Unfortunately that commit doesn't actually make simd support the default, unlike what the commit message suggests.
@bjorn3 bjorn3 mentioned this issue Aug 15, 2020
Merged
@vks vks mentioned this issue Aug 24, 2020
Closed
vks added a commit to vks/rand that referenced this issue Aug 24, 2020
@vks
Fix chacha performance
ad2ea0a 
This reverts a change from rust-random#979 that introduced a massive performance
regression by disabling SIMD for `rand_chacha`.

Likely, the behavior of `ppv-lite86` should rather be fixed. This change
serves as a workaround until a fixed version is available.

Fixes rust-random#1017.
@vks vks mentioned this issue Aug 24, 2020
Merged
@dhardy dhardy mentioned this issue Aug 28, 2020
Closed
19 tasks
@vks vks closed this as completed in #1023 Aug 28, 2020
vks added a commit that referenced this issue Aug 28, 2020
@vks
Fix chacha performance
fbcfa22 
This reverts a change from #979 that introduced a massive performance
regression by disabling SIMD for `rand_chacha`.

Likely, the behavior of `ppv-lite86` should rather be fixed. This change
serves as a workaround until a fixed version is available.

Fixes #1017.
@vks vks added this to the 0.8 release milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8 release
Development

Successfully merging a pull request may close this issue.

Fix chacha performance vks/rand
2 participants
@vks @bjorn3