Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.4.0 #81

Closed
bvssvni opened this issue Nov 8, 2015 · 6 comments
Closed

Bump to 0.4.0 #81

bvssvni opened this issue Nov 8, 2015 · 6 comments

Comments

@bvssvni
Copy link
Contributor

bvssvni commented Nov 8, 2015

Currently the libc is updated in the Cargo.toml but not yet published. When publishing, it is a good idea to bump the first non-zero number to avoid breaking existing code downstream.

@huonw
Copy link
Contributor

huonw commented Nov 9, 2015

Why is this necessary? As far as I know rand doesn't expose anything from libc directly so it shouldn't be a breaking changing to use a higher version of libc.

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 9, 2015

@huonw You're right.

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 9, 2015

It seems the changes since 0.3.11 are non-breaking, so it is possible that bumping to 0.3.12 won't break downstream crates.

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 9, 2015

rand depends on winapi, which depends on kernel32-sys. Since winapi uses a "*" version of kernel32-sys, it means that everything breaks anyway. Might as well just bump it 0.3.12. See retep998/winapi-rs#238

@bvssvni bvssvni mentioned this issue Nov 9, 2015
@retep998
Copy link
Contributor

retep998 commented Nov 9, 2015

Since winapi uses a "*" version of kernel32-sys

winapi only dev depends on the -sys crates, so it doesn't apply to downstream consumers.

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 9, 2015

@retep998 Right. My mistake.

@bvssvni bvssvni closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants