New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serde support for ChaCha #1124
serde support for ChaCha #1124
Conversation
The new getters correspond to existing setters.
Equivalent to the previous implementation, but clearer in intent. The representable-abstract-state framework introduced here is general-purpose and can also be used e.g. for serialization.
The format is semver-stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Could you please update the changelog?
@vks: CHANGELOG updated. While we're here, I also snuck in a small refactor of the internal API. The numbered-stream-param concept is now internal to guts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! The test failures are on nightly only, which is not blocking this from getting merged.
Yeah, the test failure occurs on master too. It looks like serde is broken on nightly, because of this bug in a dependency: rust-lang/packed_simd#320 |
See #1101.