Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .choices() method to the Slice distribution #1402

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Add .choices() method to the Slice distribution #1402

merged 6 commits into from
Mar 7, 2024

Commits on Mar 3, 2024

  1. Add .choices() method to the Slice distribution 

    Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4364102 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry (I hope this is correct?) 

    Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    ebeaeb3 View commit details
    Browse the repository at this point in the history

  3. Rename Slice::choices() -> Slice::num_choices() 

    Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    5df12b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Use choices struct field at creation time instead of using unsafe at … 

    …call time

Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1f08009 View commit details
    Browse the repository at this point in the history

  2. Use ? instead of match 

    Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f8b8b77 View commit details
    Browse the repository at this point in the history

  3. Name field better 

    Signed-off-by: Justus Fluegel <justusfluegel@gmail.com>
    @JustusFluegel
    JustusFluegel committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    41b044a View commit details
    Browse the repository at this point in the history