Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
entry#1311 show-cases an issue with our PERT implementation. The simplest fix I found was to also use the special-case of
v
when2*mode - min - max == 0
. A better fix can be found in the R package mc2d, duplicated here.Calculations are straightforward:
As the R source shows, we can easily calculate
mode
frommean
. Since our argument order (min, max, mode
) is already unusual, I replaced the constructor with a builder pattern.