Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benches CI job #1456

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix benches CI job #1456

merged 2 commits into from
May 24, 2024

Conversation

newpavlov
Copy link
Member

In the previous version the commands were executed for the root workspace, from which the benches crate is excluded.

@newpavlov newpavlov requested a review from dhardy May 24, 2024 13:41
dhardy
dhardy requested changes May 24, 2024
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove --all from the cargo commands.

See rust-lang/cargo#13962

@dhardy dhardy merged commit 6a46506 into master May 24, 2024
15 checks passed
@dhardy dhardy deleted the benches branch May 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @dhardy