Rename uniform #369
Rename uniform #369
Conversation
Cargo.toml
Outdated
| @@ -29,7 +29,7 @@ serde-1 = ["serde", "serde_derive"] # enables serialisation for PRNGs | |||
| members = ["rand_core"] | |||
|
|
|||
| [dependencies] | |||
| rand_core = { version = '0.1.0-pre.0', default-features = false } | |||
| rand_core = { path="rand_core", default-features = false } | |||
There was a problem hiding this comment.
An actual version is needed for making a release of rand itself. Are there changes in rand_core that mean we cannot use the pre-release now?
There was a problem hiding this comment.
I expected rand_core would be released first as 0.1, and shortly after that rand 0.5. Or do you want to make 0.5 depend on a pre-release version?
There was a problem hiding this comment.
Sorry, this comment should be in #366.
Do we have any changes to rand_core besides a few documentation tweaks? I don't think so, so I don't see why we can't still use the pre-release here and update that to a 0.1 release some time before 0.5?
There was a problem hiding this comment.
I am not sure I follow. Do you want to do another pre-release of Rand? Or do you want to keep building with the crates.io version of rand_core on master? In that case we would have to disable cargo-deadlinks on the CI.
README.md
Outdated
| @@ -84,7 +84,7 @@ The `rand` crate provides: | |||
| - pseudo-random number generators: `StdRng`, `SmallRng`, `prng` module | |||
| - convenient, auto-seeded crypto-grade thread-local generator: `thread_rng` | |||
| - `distributions` producing many different types of random values: | |||
| - `Uniform`-ly distributed integers and floats of many types | |||
| - a `Standard` distribution for integers, floats, and user types | |||
There was a problem hiding this comment.
integers, floats, and derived types including tuples, arrays and
Option
Maybe.
pitdicker
force-pushed
the
rename_uniform
branch
from
972ff49
to
1d9eb77
Compare
pitdicker
force-pushed
the
rename_uniform
branch
from
1d9eb77
to
0dab5bf
Compare
Based on top of #366.