Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Error::description and Error::cause #920

Merged

Conversation

AnderEnder
Copy link
Contributor

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon. Error::cause has been documented as deprecated from Error::cause has already been deprecated since 1.33.0.

This PR:

  • Removes an implementation of description and cause in WeightedError
  • Moves msg implementation into Display::fmt

Related PR: rust-lang/rust#66919

Copy link
Collaborator

@vks vks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes our MSRV (1.32.0) test runner, so fine with me too, and we don't really need a changelog entry for this.

@dhardy dhardy merged commit 5643fd5 into rust-random:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants