Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding error fix on WeightedIndex::update_weights() #955

Closed
wants to merge 1 commit into from
Closed

Rounding error fix on WeightedIndex::update_weights() #955

wants to merge 1 commit into from

Commits on Mar 25, 2020

  1. Bugfix for panic on WeightedIndex::update_weights 

    WeightedIndex::update_weights() uses subtraction on old_w. Rounding errors, particularly on f32, may bring total_weight to below 0. This PR makes sure this situation results in an error.
    @facorread
    facorread committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    89b3f43 View commit details
    Browse the repository at this point in the history