Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsafe code from SeedableRng::seed_from_u64 #962

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

Shnatsel
Copy link
Contributor

@Shnatsel Shnatsel commented Apr 4, 2020

u32::to_ne_bytes() has been stabilized in Rust 1.32, so this does not bump MSRV.

I haven't benchmarked it this change, but since seed generation is done once per RNG, it's not going to be a performance bottleneck either way.

rand_core/src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants