Support RocksDB transaction. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuanliu
changed the title
ryoqun
reviewed
Nov 10, 2021
ryoqun
reviewed
Nov 10, 2021
yiyuanliu
changed the title
ryoqun
reviewed
Nov 29, 2021
|
wow great progress! i'll review this in depth later |
merge two-phase commit implementation.
|
Resolve conflicts please. |
# Conflicts: # src/backup.rs # src/db.rs # tests/test_db.rs
aleksuss
reviewed
May 5, 2022
fix: optimistic db write batch
Make DBCommon suitable for checkpointing
# Conflicts: # src/backup.rs # src/checkpoint.rs # src/db.rs # src/db_iterator.rs
aleksuss
requested changes
Jul 27, 2022
|
@yiyuanliu do you plan to finish this PR? |
I will finish it, but it will take some time. Due to a job change, I've left the project I was working on when I built this PR. I'm sorry I haven't been able to find the time to work on this PR for a while. |
added 2 commits
July 27, 2022 15:34
# Conflicts: # src/backup.rs # src/checkpoint.rs # src/db.rs # src/db_iterator.rs
Closed
aleksuss
approved these changes
Jul 28, 2022
stanislav-tkach
approved these changes
Aug 4, 2022
| // | ||
|
|
||
| use crate::ffi; | ||
| use core::panic; |
There was a problem hiding this comment.
Why is the core::panic import needed?
There was a problem hiding this comment.
I'll remove it later but for now, I merge it as is.
vldm
pushed a commit
to velas/rust-rocksdb
that referenced
this pull request
Sep 8, 2022
msmouse
pushed a commit
to aptos-labs/rust-rocksdb
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building a project which uses RocksDB transaction. However,
rust-rocksdbdoesn't support transaction. PR #250 has not been updated in a long time and does not appear to be maintained.This PR wants to provide support for transactions with minimal impact on existing code. I have finished wrapping RocksDB TransactionDB, and the basic functionality is tested. The next step is to provide support for Optimistic TransactionDB.
Related to: #529 #144