Enable librocksdb-sys to be built by rustc_codegen_cranelift #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Mar 22, 2023
aleksuss
approved these changes
Mar 22, 2023
|
Hey guys , the CI failed on the MacOS tests , but it doesn't seem related to the changes introduced by this PR. Can you take a look at it or give me some idea on how to fix it ? |
This was referenced Mar 23, 2023
Shylock-Hg
pushed a commit
to Shylock-Hg/rust-rocksdb
that referenced
this pull request
Mar 29, 2024
…-rocksdb#760) added next level of output level SST's metadata for compactions Signed-off-by: hillium <yujuncen@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to build
librocks-sysusingrustc_codegen_cranelift, you encounter a panic error caused by anunwrapfunction in thebuild.rsfile. The error occurs because theunwrapfunction is attempting to access theCARGO_CFG_TARGET_FEATUREenvironment variable, which is not available in the cranelift platform.This PR adds a condition to check that the env variable actually exists instead of unwrapping it.