Improve naming of some of the new Options methods #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, totally forgot that Should we provide a deprecation path? or scrap the renaming? |
None of these methods have been in a past released version so I don't think we should worry about backwards compatibility. Changes as follows: - Renamed ``compression`` to ``set_compression_type``. I think this is a much clearer name - Renamed ``add_merge_operator`` to ``set_merge_operator`` and ``add_comparator`` to ``set_comparator``. Both of these methods replace the entire value of their respective option so "add" is the wrong term to use here. - Renamed ``set_block_cache_size_mb`` to ``rocksdb_options_optimize_for_point_lookup``. To match RocksDB's API
|
@space If you're happy with the renaming, we could keep the old versions around and decorate them with this: https://github.com/rust-lang/rfcs/blob/master/text/1270-deprecation.md#intended-use |
|
Yeah! I'm in favor of having the old ones pass-through to the new ones, and have deprecation markings on them! |
|
Cheers @spacejam! Changes made in last commit |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69
None of these methods have been in a past released version so I don't think we need to worry about backwards compatibility.
Changes as follows:
compressiontoset_compression_type. I think this is a much clearer nameadd_merge_operatortoset_merge_operatorandadd_comparatortoset_comparator. Both of these methods replace the entire value of their respective option so "add" is the wrong term to use here.set_block_cache_size_mbtorocksdb_options_optimize_for_point_lookup. To match RocksDB's API