-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont generate the bindings in src/bindings.rs #10
Comments
Update: The stale IDE results were caused by IntelliJs Rust plugin when Anyway, if we want to suppport different feature sets for the binding generation, putting To support a different skia configuration, I also started to experiment to put the complete skia / ninja output into Closing this because the original problem does not appear anymore. We may need to takle this problem again if we want to support multiple features. |
I'm reopening this, because Rust / Cargo release version 1.33 might affect us: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#cargo |
This issue seems to stick with us until it gets fixed properly. Currently, there are two problems caused by it:
Blocked by:
|
Is this in any way related to how |
@JackRedstonia Sounds unrelated, every time the build scripts runs from within a crate, binaries are downloaded. I suppose that there should be a test if matching binaries already exist. |
This messes up compilation dependency tracking and also - I think - produces stale IDE results in dependent projects when
cargo check
is used andINIT_SKIA
is not set, because the cargo project is always out of date after the bindings are regenerated. I also assume that's why the check forINIT_SKIA
exists in thebuild.rs
script.I've tried the following:
OUT_DIR
and include them like suggested in https://rust-lang.github.io/rust-bindgen/tutorial-4.htmlResult: Works, no stale results, but IDE (CLion) (and probably others) does not pick up the binding's symbols, probably because of the macro use.
Next step is to patch mtime of the generated file
src/bindings.rs
in thebuild.rs
script. This can only be a temporary solution primarily targeted for IDE support, because AFAIK we can not write in thesrc
directory for cargo package generation anyway.The text was updated successfully, but these errors were encountered: