Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review core/ wrappers #113

Merged
merged 144 commits into from Jun 15, 2019
Merged

Review core/ wrappers #113

merged 144 commits into from Jun 15, 2019

Conversation

pragmatrix
Copy link
Member

@pragmatrix pragmatrix commented May 13, 2019

To prepare for the completion of the wrappers in include/core/, I'd like to do an initial review to collect further TODOs and details about what is needed to complete them all.

Review process:

  • Go through all files one by one.
    • Consider fixing TODOs.
    • Prefer impl Trait over generic parameters.
  • Go over all implementation files and see if they comply to the conclusion in Try to avoid prefixes for wrapped, nested C++ types. #81.
  • Use impl Trait wherever possible in all Rust files (Replace generic arguments with impl Trait wherever possible. #102).
  • Implement all functions that are unimplemented! to prevent surprise bombs.
  • Go through all remaining TODOs again.
  • Add the get_ prefix to all functions that are not actually getters.
  • Support SkFlattenable.
  • Replace all enum [Name] {} static class wrappers with modules.
  • Do a final review of all the changes.
  • Clippy.
  • Update versions (Cargo.toml & deprecated attributes) (predicted: 0.12.0)!

This PR closes #81 and closes #102.

@pragmatrix pragmatrix added the enhancement New feature or request label May 13, 2019
@pragmatrix pragmatrix added this to the API Complete milestone May 13, 2019
@pragmatrix pragmatrix self-assigned this May 13, 2019
@pragmatrix pragmatrix marked this pull request as ready for review June 15, 2019 19:15
@pragmatrix pragmatrix merged commit 3c72178 into master Jun 15, 2019
@pragmatrix pragmatrix deleted the review-core branch June 18, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant