Fix SKIA_USE_SYSTEM_LIBRARIES on Linux #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with system libraries, dependencies like wuffs still needs
to be pulled:
```
ninja: error: '../../../../../../../../../.cargo/git/checkouts/rust-skia-archrv-ea99b69400d8833f/7ad5220/skia-bindings/skia/third_party/externals/wuffs/release/c/wuffs-v0.3.c', needed by 'obj/third_party/externals/wuffs/release/c/libwuffs.wuffs-v0.3.o', missing and no known rule to make it
```
Additionally, if `SKIA_USE_SYSTEM_LIBRARIES=true` and
`FORCE_SKIA_BUILD=true`, `binary_cache::resolve_dependencies` will not
be called, leaving the intended Skia source directory empty:
```
thread 'main' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/skia-bindings-0.62.0/build_support/skia/config.rs:315:10:
gn error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
hack3ric
force-pushed
the
fix-use-system-deps
branch
from
062b50c
to
328a4bd
Compare
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Oct 14, 2023
De-vendor Skia dependencies by making `SKIA_USE_SYSTEM_LIBRARIES` actually working; to be upstreamed to Arch. Related upstream PRs (for now): - rust-skia/rust-skia#851 - rust-skia/rust-skia#852 - rust-skia/rust-skia#854 - google/skia#146
|
All the changes look reasonable. Thank you for clarifying the behavior of SKIA_USE_SYSTEM_LIBRARIES. Merging now. |
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Oct 14, 2023
De-vendor Skia dependencies by making `SKIA_USE_SYSTEM_LIBRARIES` actually working; to be upstreamed to Arch. Related upstream PRs (for now): - rust-skia/rust-skia#851 - rust-skia/rust-skia#852 - rust-skia/rust-skia#854 - google/skia#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKIA_USE_SYSTEM_LIBRARIES doesn't work as expected in two ways:
When building with system libraries, dependencies like wuffs still needs to be pulled:
If
SKIA_USE_SYSTEM_LIBRARIES=trueandFORCE_SKIA_BUILD=true,binary_cache::resolve_dependencieswill not be called, leaving the intended Skia source directory empty when callinggn gen:System dependencies isn't actually linked, causing errors like:
Adding all possible dependencies to
link_librarieswould fix, and should not link to unused libraries (-Wl,--as-neededis on by default)