Replace project codebase with rss-rs #24
Conversation
frewsxcv
commented
Sep 2, 2016
frewsxcv
commented
- frewsxcv/rust-rss recently became rust-syndication/rss
- frewsxcv/russ-rss codebase will be replaced by jameshurst/rss-rs codebase
- Attribute values will return an error if the bytes aren't valid utf8 - Error::XmlParsing includes the byte offset
| git push -qf https://${TOKEN}@github.com/${TRAVIS_REPO_SLUG}.git gh-pages | ||
|
|
||
| before_script: | ||
| - pip install 'travis-cargo<0.2' --user && export PATH=$HOME/.local/bin:$PATH |
There was a problem hiding this comment.
I'm not opposed to just relying on https://docs.rs/rss/ now that docs.rs is done
There was a problem hiding this comment.
Though I'm also not opposed to keeping this travis-cargo infra in place
There was a problem hiding this comment.
Using docs.rs would probably be a good idea. Maybe we could use both, use travis-cargo for documentation on the master branch and use docs.rs for the current released version.
|
|
||
| ## Todo | ||
|
|
||
| * Writing support |
There was a problem hiding this comment.
This is the main concern I have about merging rss-rs as is. Right now, rust-rss supports generating strings of XML from the RSS structures. It feels like a regression to remove that support.
There was a problem hiding this comment.
Writing support is definitely something I want to get in. If we were to merge this now we should make sure that writing is implemented before the next crates.io release.
|
LGTM 👍 |
|
@jameshurst Is there any way I could help with the writing support for the new codebase? |
|
@frewsxcv I'm pretty far along with the writing support so far. Did the old codebase do any escaping? From my initial glance it doesn't look like it did. If not then I'll commit writing without any escaping for now. |
|
I didn't explicitly add any escaping, and I'm guessing RustyXML did not as well, so I think it's safe to assume escaping was not implemented. |
|
I took a look at the RustyXML source and it doesn't do any escaping. |
