Syndication support #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read process statically maps element names to functionality, so abstraction through the FromXml trait isn't required. The trait complicates use of additional contextual data (such as namespace) in the parsing implementation as required. This commit removes the FromXml trait and exposes the parsing implementations directly.
Documents are free to define a local prefix for a given namespace so parsing should not hard-code a specific prefix (e.g. "dc" for Dublin Core). This commit records all configured namespaces during the initial parse and uses these namespaces to instantiate the appropriate extensions as they are encountered.
The RSS syndication module allows feeds to specify how often they are updated as a hint to crawlers. This commit adds support for this module as an extension.
|
Hmm, that build passed when I built it locally (1.34.1). Will investigate! |
Fixes for various issues reported by clippy.
markpritchard
force-pushed
the
syndication-support
branch
from
c1aaed0
to
4b975c7
Compare
UpdatePeriod missing serde derive.
frewsxcv
approved these changes
May 11, 2019
|
Hi Corey,
Thanks for approving! I don't think they are breaking - the tests are
basically unchanged, as is the API. The extension namespaces are no longer
always added (e.g. dublincore) but they were superfluous anyway.
Cheers,
Mark
…On Sun, May 12, 2019 at 7:10 AM Corey Farwell ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good! Are any of these changes considered breaking changes? Doesn't
look like it...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB62IVS2JBYIRM7V3UE32F3PU4Y5RANCNFSM4HK7RHHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add support for the RSS Syndication module (http://purl.org/rss/1.0/modules/syndication/) which provides the period at which feeds are updated.
The standard uses the
sylocal prefix, whereas many feeds usesynso this PR also introduces dynamic local prefixes for namespaces.