Remove dependency on failure #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I just noticed that the sibling This handwritten code for the error is really not much, and it doesn't seem worth pulling in more dependencies to avoid it to me... |
frewsxcv
approved these changes
Dec 29, 2019
|
I took the liberty of including an updated from the deprecated |
|
Now that rust-syndication/atom#18 has been merged, this change will bring the design of the errors in rss and atom in line. Anything else I need to do before this can be merged? |
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be a dependency of
quick-xml, but it was removed in version 0.17 by tafia/quick-xml#170.rssdepended on it previously to work withquick-xml::Error, but this is no longer necessary. Keeping it meansrssis pulling in a lot of other unnecessary dependencies.This change also updates to stop using the deprecated parts of std's
Errortrait.