Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove from_url feature #88

Merged
merged 1 commit into from
Jun 4, 2020
Merged

remove from_url feature #88

merged 1 commit into from
Jun 4, 2020

Conversation

andy128k
Copy link
Member

@andy128k andy128k commented Jun 4, 2020

Closes #84

@andy128k andy128k force-pushed the remove-reqwest branch 2 times, most recently from 7d1fa01 to b773a87 Compare June 4, 2020 19:55
@AnderEnder
Copy link
Contributor

@andy128k :

rg from_url .
./src/error.rs
26:    #[cfg(feature = "from_url")]
29:    #[cfg(feature = "from_url")]
39:            #[cfg(feature = "from_url")]
41:            #[cfg(feature = "from_url")]
54:            #[cfg(feature = "from_url")]
56:            #[cfg(feature = "from_url")]
74:#[cfg(feature = "from_url")]
81:#[cfg(feature = "from_url")]

./src/lib.rs
32://! **Note**: This requires enabling the `from_url` feature.
37://! let channel = Channel::from_url("http://example.com/feed.xml").unwrap();
104:#[cfg(feature = "from_url")]

@andy128k
Copy link
Member Author

andy128k commented Jun 4, 2020

@AnderEnder thanks. Those are also removed.

@andy128k andy128k mentioned this pull request Jun 4, 2020
@AnderEnder AnderEnder merged commit 0bf443c into master Jun 4, 2020
@AnderEnder AnderEnder deleted the remove-reqwest branch June 4, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removal of from_url feature
2 participants