Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non sized warning for ViaXml #9

Merged
merged 1 commit into from
Oct 16, 2015
Merged

Fix non sized warning for ViaXml #9

merged 1 commit into from
Oct 16, 2015

Conversation

tsurai
Copy link
Contributor

@tsurai tsurai commented Oct 16, 2015

Tiny PR fixing a warning in advance before it becomes a HARD ERROR in the next release.

src/lib.rs:117:5: 117:59 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277]
src/lib.rs:117     fn from_xml(elem: Element) -> Result<Self, ReadError>;
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/lib.rs:117:5: 117:59 help: run `rustc --explain E0277` to see a detailed explanation
src/lib.rs:117:5: 117:59 note: `Self` does not have a constant size known at compile-time
src/lib.rs:117:5: 117:59 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.
src/lib.rs:117     fn from_xml(elem: Element) -> Result<Self, ReadError>;
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@frewsxcv
Copy link
Member

Thanks!

frewsxcv added a commit that referenced this pull request Oct 16, 2015
Fix non sized warning for ViaXml
@frewsxcv frewsxcv merged commit 8d7e101 into rust-syndication:master Oct 16, 2015
@frewsxcv
Copy link
Member

Just published version 0.2.1 that includes this change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants