Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy warnings #93

Merged
merged 1 commit into from
Jun 7, 2020
Merged

fix clippy warnings #93

merged 1 commit into from
Jun 7, 2020

Conversation

AnderEnder
Copy link
Contributor

@AnderEnder AnderEnder commented Jun 7, 2020

Example:

warning: called `.as_ref().map(String::as_str)` on an Option value. This can be done more directly by calling `self.email.as_deref()` instead
  --> src/extension/itunes/itunes_owner.rs:73:9
   |
73 |         self.email.as_ref().map(String::as_str)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using as_deref instead: `self.email.as_deref()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 97.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          24       24           
  Lines        1724     1724           
=======================================
  Hits         1371     1371           
  Misses        353      353           
Impacted Files Coverage Δ
src/channel.rs 79.28% <88.88%> (ø)
src/category.rs 91.66% <100.00%> (ø)
src/extension/itunes/itunes_category.rs 100.00% <100.00%> (ø)
src/extension/itunes/itunes_channel_extension.rs 82.66% <100.00%> (ø)
src/extension/itunes/itunes_item_extension.rs 85.50% <100.00%> (ø)
src/extension/itunes/itunes_owner.rs 100.00% <100.00%> (ø)
src/extension/mod.rs 71.42% <100.00%> (ø)
src/image.rs 82.00% <100.00%> (ø)
src/item.rs 81.10% <100.00%> (ø)
src/source.rs 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885e86a...2036e7a. Read the comment docs.

@AnderEnder AnderEnder marked this pull request as ready for review June 7, 2020 15:22
@andy128k andy128k merged commit 2663695 into master Jun 7, 2020
@andy128k andy128k deleted the fix-clippy-warnings branch June 7, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants