Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introduction #43

Closed
wants to merge 28 commits into from
Closed

Add introduction #43

wants to merge 28 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2016

I started a branch to update the introduction. I added the first three paragraphs of the blog post mentioned in issue #4 and I added a bit more as well. Before I continue, I'd like some feedback as far as wording and topics go so I can make it better.

fixes #4

@cbreeden
Copy link
Collaborator

Good stuff, I like it so far

@ghost
Copy link
Author

ghost commented Oct 28, 2016

I removed the third paragraph from the blog post. It sounds like it should be in a README instead of here.

@ghost ghost mentioned this pull request Oct 28, 2016
intro.md Show resolved Hide resolved
Copy link

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first draft, I left a bunch of comments in-line.

If you rename the about.md files to Readme.md, they will be rendered directly on the subdirectory pages on Github.

anti_patterns/about.md Show resolved Hide resolved
idioms/about.md Show resolved Hide resolved
intro.md Show resolved Hide resolved
patterns/about.md Show resolved Hide resolved
patterns/about.md Show resolved Hide resolved
patterns/about.md Show resolved Hide resolved
patterns/about.md Show resolved Hide resolved
patterns/about.md Show resolved Hide resolved
refactoring/about.md Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 3, 2016

@killercup Thanks for all your great feedback!

@cbreeden
Copy link
Collaborator

cbreeden commented Nov 3, 2016

Do you have ideas for what you would like to see the in functional and refactoring folder?

@ghost
Copy link
Author

ghost commented Nov 3, 2016

I was thinking something similar to what exists in the patterns folder, probably with an altered template. So far my ideas are:

  • functional
    • currying
    • higher-order functions
    • collections
  • refactoring
    • refactoring from unwrap to Result
    • refactoring from enum to Option

@DaseinPhaos DaseinPhaos mentioned this pull request Feb 15, 2017
@pickfire
Copy link
Contributor

The user became ghost, how should this be handled?

@simonsan simonsan added C-addition Category: Adding new content, something that didn't exist in the repository before C-enhancement Category: Enhancements to content labels Dec 31, 2020
@simonsan simonsan changed the title WIP: Add introduction Add introduction Dec 31, 2020
@simonsan simonsan added the S-review Status: A PR that is currently under review or where a review is the next step label Dec 31, 2020
simonsan added a commit that referenced this pull request Jan 1, 2021
@simonsan simonsan mentioned this pull request Jan 1, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 1, 2021

@pickfire We will continue discussing about the content of this PR in #117

Closing this PR.

@simonsan simonsan closed this Jan 1, 2021
simonsan added a commit that referenced this pull request Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-addition Category: Adding new content, something that didn't exist in the repository before C-enhancement Category: Enhancements to content S-review Status: A PR that is currently under review or where a review is the next step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants