sound: add clippy lint checks #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subtraction between unsigned integers is made, which by default panics on overflow. However, we don't really need to know the difference, only that it is not zero or less. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Suggested by lint https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Add basic lints to deny unidiomatic or potentially bad code. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
epilys
requested review from
mathieupoirier,
stsquad,
vireshk and
stefano-garzarella
as code owners
vireshk
approved these changes
Nov 2, 2023
|
I managed to screw up and merge this without approval from you guys. I was trying to enable auto-merge only :( Can you guys please check the pull request again and see if there is something worth fixing ? |
No problem, can happen ;-)
I left some comments that we can surely fix in another PR. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #513
Summary of the PR
Add basic lints to deny unidiomatic or potentially bad code.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.