vhost_user: expand error messages for clarity #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsquad
force-pushed
the
expand-vhost-user-errors
branch
3 times, most recently
from
9b985bd
to
aa3a436
Compare
We can wrap up the feature checking into helpers to reduce the amount of boilerplate code while enabling us to use a more idiomatic ?; exit path on error. Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
stsquad
force-pushed
the
expand-vhost-user-errors
branch
from
aa3a436
to
004c3e9
Compare
|
LGTM, I think we can merge this one once the coverage number is fixed to the new value. Thanks @stsquad ! |
The InvalidOperation error type covers a wide range of error cases which can be inscrutable when passed to the user. To help with this we: - add a textual reason field to the error message - create InactiveFeature for use of un-neogitated features - create InactiveOperation for use of un-negotiated protocol extensions Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
The spec has been converted to .rst and now generated a nicer rendered version whenever it is updated in QEMU's master branch. Lets use it instead. Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
stsquad
force-pushed
the
expand-vhost-user-errors
branch
from
004c3e9
to
ca6a667
Compare
stsquad
requested review from
eryugey,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
|
I have a small patches waiting for vhost-user-master and vhost-device once the version for this crate is bumped . |
stefano-garzarella
approved these changes
Jul 22, 2022
sboeuf
approved these changes
Jul 22, 2022
|
Does this PR not get automatically merged once approved or does it need to be done manually? |
No it still has to be merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The InvalidOperation error type covers a wide range of error cases
which can be inscrutable when passed to the user. To help with this
we:
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.