Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building on OSX #88

Closed
bvssvni opened this issue Oct 28, 2014 · 5 comments
Closed

Error when building on OSX #88

bvssvni opened this issue Oct 28, 2014 · 5 comments

Comments

@bvssvni
Copy link
Contributor

bvssvni commented Oct 28, 2014

https://gist.github.com/bvssvni/162457f2d99609060ef5

@tomaka
Copy link
Contributor

tomaka commented Oct 28, 2014

cc @DavidPartouche

@tomaka tomaka added bug and removed A-iOS labels Oct 28, 2014
@ghost
Copy link

ghost commented Nov 5, 2014

@bvssvni I've committed the fix in DavidPartouche/rust-cocoa, could you try to compile again and confirm that it works on your machine?

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 5, 2014

I get this:

Build failed, waiting for other jobs to finish...
Failed to run custom build command for `cocoa v0.1.0 (https://github.com/DavidPartouche/rust-cocoa#aa8982be)`
Process didn't exit successfully: `make -f makefile.msgsend` (status=2)
--- stdout
cc -Wall src/msgsend.m -o /Users/sven/rust/glutin/target/native/cocoa-ebcc268ffcd672e2/msgsend.o -c

--- stderr
src/msgsend.m:105:1: error: unknown type name 'NSEventSubtype'; did you mean 'NSEventType'?
NSEventSubtype invoke_msg_NSEventSubtype(id theReceiver, SEL theSelector) {
^~~~~~~~~~~~~~
NSEventType
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:56:20: note: 'NSEventType' declared here
typedef NSUInteger NSEventType;
                   ^
src/msgsend.m:106:13: error: use of undeclared identifier 'NSEventSubtype'; did you mean 'NSEventType'?
    return (NSEventSubtype)objc_msgSend(theReceiver, theSelector);
            ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:56:20: note: 'NSEventType' declared here
typedef NSUInteger NSEventType;
                   ^
2 errors generated.
make: *** [/Users/sven/rust/glutin/target/native/cocoa-ebcc268ffcd672e2/msgsend.o] Error 1

@ghost
Copy link

ghost commented Nov 5, 2014

I didn't see this error, NSEventSubtype is only available from 10.10
I've removed it from the code so now it should work.

@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 5, 2014

It works :)

@bvssvni bvssvni closed this as completed Nov 5, 2014
nox pushed a commit to nox/glutin that referenced this issue May 20, 2016
 	cocoa: Add some bare-bones menus on the Mac to conform better to the Apple Human Interface Guidelines.

Includes rust-windowing#86.

Requires servo/cocoa-rs#125.

r? @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/88)
<!-- Reviewable:end -->
tomaka added a commit that referenced this issue Aug 29, 2017
Add a `WindowBuilder::with_window_resize_callback` method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants