Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, fix icons specified on WindowBuilder not taking effect for windows created after the first one #2530

Merged

Conversation

amrbashir
Copy link
Contributor

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@amrbashir amrbashir changed the title On Windows, fix icons specified on WindowBuilder not taking effect for windows created after the firt one On Windows, fix icons specified on WindowBuilder not taking effect for windows created after the first one Oct 26, 2022
@amrbashir amrbashir force-pushed the fix/windows/window-builder-icon branch from 5ec3afe to 5a5791a Compare October 26, 2022 17:00
@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - windows labels Nov 2, 2022
src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
@msiglreith msiglreith merged commit 50bbc85 into rust-windowing:master Nov 6, 2022
@amrbashir amrbashir deleted the fix/windows/window-builder-icon branch November 6, 2022 20:33
@amrbashir amrbashir restored the fix/windows/window-builder-icon branch November 6, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - windows
Development

Successfully merging this pull request may close these issues.

None yet

3 participants